This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH/ARM] Fix support of longjmp for ARM Linux.
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>, Daniel Jacobowitz <dan at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 29 Apr 2010 14:49:43 +0100
- Subject: Re: [PATCH/ARM] Fix support of longjmp for ARM Linux.
- References: <1272547868.19716.13.camel@e102111-lin.cambridge.arm.com>
On Thu, 2010-04-29 at 14:31 +0100, Matthew Gretton-Dann wrote:
> Hi,
>
> Can someone please review and comment on the attached patch?
>
> The patch fixes support for longjmp on ARM Linux. Dependent on the FP
> model in use the location of the PC to use as the long jump return value
> is stored in different locations in the long jump buffer. Currently gdb
> uses a hard-coded value which works for only one FP model, this patch
> corrects this.
>
> A suggested ChangeLog is:
>
> 2010-04-29 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * arm-linux-tdep.c (ARM_LINUX_JB_PC): Remove.
> (ARM_LINUX_JB_PC_FPA): Add, offset of PC in longjmp buffer for
> FPA.
> (ARM_LINUX_JP_PC_EABI): Add, offset of PC in longjmp buffer for
> EABI.
> (arm_linux_init_abi): Set up JB_PC field dependent on FP model
> in use.
>
> Thanks,
>
> Matt
This is ok.
Danniel, can we give Matt write-after a commit bit, please. He's
already got an account for binutils work.
R.