This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: New ARI warning Sat Apr 24 01:55:22 UTC 2010
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Joel Brobecker'" <brobecker at adacore dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 30 Apr 2010 00:44:03 +0200
- Subject: RE: New ARI warning Sat Apr 24 01:55:22 UTC 2010
- References: <20100424015523.GA5071@sourceware.org> <20100427164049.GF2951@adacore.com>
> > 1331a1332
> > > gdb/solib-svr4.c:295: code: UCASE function: Function name is
> uppercase.
> > gdb/solib-svr4.c:295:IGNORE_FIRST_LINK_MAP_ENTRY (struct so_list *so)
>
> This one, on the other hand, is easy to fix, but requires discussion.
> It seems to the current style for this sort of routine in solib-svr4.c.
> I don't know why we decided to name these functions using all uppercase
> letters, but it's apparently against the ARI.
>
> Examples of all upper-case functions: LM_ADDR_FROM_LINK_MAP,
> HAS_LM_DYNAMIC_FROM_LINK_MAP, LM_DYNAMIC_FROM_LINK_MAP, LM_ADDR_CHECK,
> etc.
>
> It's really easy to change their name, but maybe there is a reason
> other
> than historical for them being all uppercase (maybe they were macros).
> Something to look at during a rainy day...
Another big UCASE provider is gnu-nat.c,
but looking at the source,
functions like S_exception_raise_request
is only defined and used nowhere... which probably means that
it is recognized as some special function.
Is this true?
If it is, we probably cannot change the name.
In such case, I would propose to put
a /* ARI: UCASE */ comment to mark that exceptional
use of uppercased function name as legitimate...
Could someone confirm this?
Pierre
as ARI maintainer