This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/RFA] Adding support for GNAT Ravenscar run-time lib
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jerome Guitton <guitton at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 5 May 2010 10:14:22 -0700
- Subject: Re: [RFC/RFA] Adding support for GNAT Ravenscar run-time lib
- References: <1272230544-2876-1-git-send-email-guitton@adacore.com>
Hello Jerome,
> 2010-04-25 Jerome Guitton <guitton@adacore.com>
>
> * ravenscar-thread.c, ravenscar-thread.h, ravenscar-sparc-thread.c:
> New function.
> * configure.tgt: Add ravenscar-thread.o and ravenscar-sparc-thread.o
> to the target objects for sparc-elf.
I don't see any issue with this patch, but it would be nice if someone
who knows the target stack a little better than I do could take a quick
look at how we do things...
In the meantime:
> +++ b/gdb/ravenscar-sparc-thread.c
> @@ -0,0 +1,184 @@
> +/* Ravenscar ERC32 target support.
^^^^^
I noticed that we left erc32 everywhere in this patch. Insider info:
AdaCore first wrote this layer while working on an erc32 target. Hence
erc32 shows up everywhere. But from a GDB perspective, erc32 and sparc
are just the same, and thus we decided to change erc32 into sparc. We
renamed the file, but forgot to do the search&replace in the code.
We should take care of that before the commit the patch.
> + add_prefix_cmd ("ravenscar", no_class, set_ravenscar_command,
> + _("Prefix command for changing Ravenscar-specific settings"),
> + &set_ravenscar_list, "set ravenscar ", 0, &setlist);
> +
> + add_prefix_cmd ("ravenscar", no_class, show_ravenscar_command,
> + _("Prefix command for showing Ravenscar-specific settings"),
> + &show_ravenscar_list, "set ravenscar ", 0, &showlist);
We need documentation for these new commands...
--
Joel