This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] eval, valops, valarith, valprint, printcmd.c: delete unused variables.
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 07 May 2010 11:23:40 -0600
- Subject: Re: [patch] eval, valops, valarith, valprint, printcmd.c: delete unused variables.
- References: <4BE30B48.9040800@vmware.com>
- Reply-to: tromey at redhat dot com
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> struct value *
Michael> value_cast_pointers (struct type *type, struct value *arg2)
Michael> {
Michael> - struct type *type1 = check_typedef (type);
Michael> struct type *type2 = check_typedef (value_type (arg2));
Michael> struct type *t1 = check_typedef (TYPE_TARGET_TYPE (type));
Michael> struct type *t2 = check_typedef (TYPE_TARGET_TYPE (type2));
In this case I think the intent is for t1 to reference type1, and not type.
I would recommend making that change rather than deleting type1.
Tom