This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables

From: Michael Snyder <msnyder at vmware dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Fri, 07 May 2010 11:23:29 -0700
Subject: Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables
References: <4BE35310.9020704@vmware.com> <20100507031644.GZ2768@adacore.com>

Joel Brobecker wrote:

--- jv-lang.c	22 Apr 2010 23:15:41 -0000	1.83
+++ jv-lang.c	6 May 2010 23:35:37 -0000
@@ -268,8 +268,10 @@ type_from_class (struct gdbarch *gdbarch
   struct value *utf8_name;
   char *nptr;
   CORE_ADDR addr;
+#if 0
   struct block *bl;
   struct dict_iterator iter;
+#endif

Can you explain why using #if 0 instead of deleting these variables?

Because they are used in the #if 0 block just below.

Alternatively, we could remove both the variables and the #if 0 block.

Michael

References:
- [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables
  - From: Michael Snyder
- Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]