This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PING: [PATCH] properly check error return from socket() and accept() calls
- From: Ozkan Sezer <sezeroz at gmail dot com>
- To: tromey at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 27 May 2010 01:41:32 +0300
- Subject: Re: PING: [PATCH] properly check error return from socket() and accept() calls
- References: <s2r647fe9b11004062339vfe29c5fbie1a09406f1b644f7@mail.gmail.com> <m3k4sgjwhz.fsf@fleche.redhat.com>
On Fri, Apr 9, 2010 at 9:45 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Ozkan" == Ozkan Sezer <sezeroz@gmail.com> writes:
>
> Ozkan> PING.
>
> Ozkan> 2010-04-03 ?Ozkan Sezer ?<sezeroz@gmail.com>
> Ozkan> gdb/
> Ozkan> ?* ser-tcp.c (net_open): Check error return from socket() call by its
> Ozkan> ?equality to -1 not by it being negative.
> Ozkan> ?(net_close): Likewise.
> [...]
>
> It seems reasonable enough to me.
>
> Do you have a copyright assignment in place? ?TBH it isn't clear to me
> whether this patch requires one -- it is long enough, but I would say
> that there is really only one way to write this patch.
>
> Tom
>
Committed now. Thanks.
--
Ozkan