This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Test and support all cpp operator types
- From: Tom Tromey <tromey at redhat dot com>
- To: sami wagiaalla <swagiaal at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 04 Jun 2010 14:59:42 -0600
- Subject: Re: [PATCH 2/2] Test and support all cpp operator types
- References: <4BE9BE28.6080800@redhat.com> <m3ljbozrqb.fsf@fleche.redhat.com> <4BF2FAF3.5010005@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:
Sami> This patch fixes the above. It assumes that namespace names will
Sami> belong to the static and global blocks. This enables us to separate
Sami> the non-namespace iterative search from the namespace search.
Great, thanks.
One nit.
Sami> + /* look in the static block. */
Sami> + block = block_static_block (get_selected_block (0));
Sami> + make_symbol_overload_list_block (name, block);
Sami> + /* look in the global block. */
In both of these comments, the "L" in "look" should be capitalized.
Ok with this change. Thanks again.
Tom