This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Let "gcore" command accept a suffix argument
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: tromey at redhat dot com, brobecker at adacore dot com, stanshebs at earthlink dot net, stan at codesourcery dot com, msnyder at vmware dot com, gdb-patches at sourceware dot org
- Date: Tue, 22 Jun 2010 21:03:21 +0300
- Subject: Re: [RFC] Let "gcore" command accept a suffix argument
- References: <m31vioaxv0.fsf@fleche.redhat.com> <4B3BEDCC.9040103@earthlink.net> <daef60381001040642h2e8b3919u221f61d43b23d395@mail.gmail.com> <daef60381001052257q2068a8fbmaacd026b8d5cef49@mail.gmail.com> <20100106075757.GF24777@adacore.com> <daef60381001090154m36f5cf15x9f76b7073e4d126@mail.gmail.com> <20100109105557.GA2007@adacore.com> <daef60381001090717j4a658548g114950986df6279b@mail.gmail.com> <20100110054328.GD2007@adacore.com> <daef60381001100530k39fe9727s355cad73a47a2989@mail.gmail.com> <20100110140029.GF2007@adacore.com> <AANLkTinVPdwg6HuAp08wknw8DYe80LcR33tbEaRkMDXz@mail.gmail.com> <m3wrtsf4l7.fsf@fleche.redhat.com> <AANLkTilS_akNAsRbtukpkx7FgHb5u-Rsb5JkYfGvxrI9@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Hui Zhu <teawater@gmail.com>
> Date: Tue, 22 Jun 2010 15:29:03 +0800
> Cc: Stan Shebs <stanshebs@earthlink.net>, Stan Shebs <stan@codesourcery.com>,
> Michael Snyder <msnyder@vmware.com>, gdb-patches ml <gdb-patches@sourceware.org>
>
> I make a new patch according to your mails.
>
> It include the code, doc and test. Please help me review it.
Thanks. The doc parts are okay, with these two comments:
> +eval template, expressions...
> + Convert the values of one or more expressions under the control
> + of the string template to a command line and call it.
^
A comma here, please.
> +@item eval @var{template}, @var{expressions}@dots{}
> +Convert the values of one or more @var{expressions} under the control of
> +the string @var{template} to a command line and call it.
^
Same here.