RE: [RFA] testsuite avoid tcl error in gdb.threads/gcore-thread.exp

["Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>]

> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé?: Wednesday, June 23, 2010 4:42 PM
> À?: gdb-patches@sourceware.org
> Cc?: Pierre Muller
> Objet?: Re: [RFA] testsuite avoid tcl error in gdb.threads/gcore-
> thread.exp
> 
> On Wednesday 23 June 2010 14:59:09, Pierre Muller wrote:
> 
> >   Tested on gcc16 (it works again, hurrah!)
> > no changes.
> 
> I, and more importantly I guess anyone reading the archives in a
> few years, don't know what gcc16 is.  I guess it to be a machine in
> the gcc compile farm, and I guess it to be running linux, but I don't
> know for sure.  I don't know if it is x86, x86-64 or something else.
> Can
> you please state x86_64-linux, or something like that instead of
> assuming everyone else is using the gcc compile farm?

  Sorry, 
yes indeed gcc16 is just one of the machine of the gcc compile farm,
and it is a linux box base on a x86_64 CPU.
 
> >   OK to commit?
> 
> Yes, thanks. 

Thanks for the approval, patch committed.

> I was going to suggest fixing gcore.exp too, but
> it was already fixed similarly at some point:
> 
> 2007-05-14  Markus Deuling  <deuling@de.ibm.com>
> 
>         * gdb.base/gcore.exp: Initialize variable core_supported.
> 
> >  set escapedfilename [string_to_regexp
> ${objdir}/${subdir}/gcore.test]
> >  # Drop corefile
> > +global core_supported
> > +set core_supported 0
> > +
> 
> Pedantically, you don't need that "global" statement anymore.

  I still didn't really understand this:
  when I run a testsuite with
'make check'.
All individual tests are run from runtest script
which itself uses runtest procedure to execute
each .exp file using the source command.
  Thus I was thinking that the code 
inside each .exp  file was not at global level,
but only at 'runtest procedure level', and I am not even sure
which level that procedure runs.
  Could someone explain to me why we are for sure
at global level when a .exp file is sourced?

Pierre