This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Static tracepoints support
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org, Eli Zaretskii <eliz at gnu dot org>
- Date: Thu, 1 Jul 2010 18:13:01 +0100
- Subject: Re: Static tracepoints support
- References: <201006251931.57860.pedro@codesourcery.com> <201007011500.27076.pedro@codesourcery.com> <83pqz79lhg.fsf@gnu.org>
On Thursday 01 July 2010 18:10:19, Eli Zaretskii wrote:
> > From: Pedro Alves <pedro@codesourcery.com>
> > Date: Thu, 1 Jul 2010 15:00:26 +0100
> > Cc: Eli Zaretskii <eliz@gnu.org>
> >
> > On Monday 28 June 2010 13:26:38, Pedro Alves wrote:
> > > > > +with that name. With no LOCATION, uses current execution address of \n\
> > > > > +selected stack frame.\n\
> > > >
> > > > "of the selected stack frame"
> > >
> > > Fixed. Needs fixing in BREAK_ARGS_HELP; it's showing up in the help
> > > strings of all breakpoint commands.
> > >
> >
> > Here's the fix for all other breakpoint commands, but I do
> > note some sort of pattern here: it appears that "the" was
> > avoided on purpose in all the sentences as can be seen in
> > the contenxt of the patch. Would you like to review
> > the whole help string, or is this correct?
>
> "the selected stack frame" is correct here.
Okay, though I was more trying to suggest to check if the other
"the"'s are actually missing, like "With no LOCATION, uses _the_
current execution address of _the_ selected frame", and "break at
_the_ start of code for that function".
I'll apply the patch once I adjust the testsuite
accordinly (help.exp).
--
Pedro Alves