This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver


On Sun, Jul 18, 2010 at 12:01 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Ozkan Sezer <sezeroz@gmail.com> writes:
>
>> Index: server.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
>> retrieving revision 1.125
>> diff -u -p -r1.125 server.c
>> --- server.c ?7 Jul 2010 16:14:04 -0000 ? ? ? 1.125
>> +++ server.c ?17 Jul 2010 18:54:41 -0000
>> @@ -1539,7 +1539,7 @@ handle_query (char *own_buf, int packet_
>>
>> ? ? ? ?if (err == 0)
>> ? ? ? {
>> - ? ? ? sprintf (own_buf, "%llx", address);
>> + ? ? ? sprintf (own_buf, "%s", paddress(address));
>
> s/sprintf/strcpy/
>

Thanks for catching it, changing immediately to
strcpy (own_buf, paddress(address))

Still waiting for a review/comment on the fix for paddress() posted at
http://sourceware.org/ml/gdb-patches/2010-07/msg00254.html

> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 ?01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
>

--
Ozkan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]