This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH]prec: record_arch_list_add_mem add check for len
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Hui Zhu <teawater at gmail dot com>
- Date: Tue, 20 Jul 2010 13:51:04 +0100
- Subject: Re: [PATCH]prec: record_arch_list_add_mem add check for len
- References: <AANLkTiksyvVzkAiwf1Rh3yDfiY4aSsN21RwoJPBkajES@mail.gmail.com>
On Monday 19 July 2010 09:08:17, Hui Zhu wrote:
> Add this check for some code maybe len < 0.
How can len < 0 happen? Wouldn't that be a bug?
>
> Thanks,
> Hui
>
> 2010-07-16 Hui Zhu <teawater@gmail.com>
>
> * record.c (record_arch_list_add_mem): Add check for len.
>
>
> ---
> record.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- a/record.c
> +++ b/record.c
> @@ -497,6 +497,8 @@ record_arch_list_add_mem (CORE_ADDR addr
>
> if (!addr) /* FIXME: Why? Some arch must permit it... */
> return 0;
> + if (len <= 0)
> + return 0;
>
> rec = record_mem_alloc (addr, len);
>
--
Pedro Alves