This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] change unresolved to untested in namespace.exp.
- From: dje at google dot com (Doug Evans)
- To: gdb-patches at sourceware dot org
- Date: Thu, 29 Jul 2010 15:11:47 -0700 (PDT)
- Subject: [patch] change unresolved to untested in namespace.exp.
Hi.
If there are no objections, I will check this in in a couple of days.
Unresolved means something went wrong with the test run and human attention
is needed. This can happen, for example, if a previous test failed.
But that's not really the case here when the previous test ($test) xfailed.
Human intervention isn't going to help decide whether $test2 passed or failed.
ref: http://www.gnu.org/software/dejagnu/manual/x47.html
grep for UNRESOLVED
[I don't see why the code doesn't just try $test2 anyway,
regardless of whether $test failed, but I'm treating that as a
separate issue - I don't know the history of this test.
But if folks want, I can change the test to do that.]
2010-07-29 Doug Evans <dje@google.com>
* gdb.cp/namespace.exp: When "print ::cOtherFileClassVar" fails
because of an older gcc, change test2
"print ::C::OtherFileClass::cOtherFileClassVar" from unresolved
to untested.
Index: gdb.cp/namespace.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/namespace.exp,v
retrieving revision 1.23
diff -u -p -r1.23 namespace.exp
--- gdb.cp/namespace.exp 30 Jun 2010 15:58:47 -0000 1.23
+++ gdb.cp/namespace.exp 29 Jul 2010 22:01:39 -0000
@@ -199,14 +199,20 @@ gdb_test_multiple $test $test {
gdb_test $test2 " = 318"
}
-re "\\$\[0-9\].* = 318\r\n$gdb_prompt $" {
+ # Do not permit to XFAIL on recent GCCs.
if {[test_compiler_info {gcc-[0-3]-*}]
|| [test_compiler_info {gcc-4-[0-4]-*}]} {
- # Do not permit to XFAIL on recent GCCs.
setup_xfail *-*-*
+ fail $test
+ # Unresolved means human intervention is required to determine
+ # whether the test passed or failed. Since the previous test
+ # xfailed (not failed) human intervention isn't going to help here.
+ # Thus test2 is marked as untested instead of unresolved.
+ untested $test2
+ } else {
+ fail $test
+ unresolved $test2
}
- fail $test
-
- unresolved $test2
}
}