This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete]
-PASS: gdb.cp/temargs.exp: test value of P in inner_m
+FAIL: gdb.cp/temargs.exp: test value of P in inner_m
:
Okay let me take a look. Thanks for letting me know.
Apologies it took so long to get back to this I had some difficulty
setting up the environment.
The original patch:
http://sourceware.org/ml/gdb-cvs/2010-08/msg00040.html
3b26cb4b133031280fa022e2a06e58f333ed5e8d
suppressed one too many regressions. Specifically (if you look at
3b26cb4b133^) the regression on line 10185 when the tag is
DW_TAG_template_value_param and DW_AT_location != NULL.
Patch attached.
Fix defer add regression.
2010-08-20 Sami Wagiaalla <swagiaal@redhat.com>
* dwarf2read.c (new_symbol_full): Do not set list_to_add to NULL
if suppress_add == 1.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 78491c8..cd1c084 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -10330,7 +10330,6 @@ new_symbol_full (struct die_info *die, struct type *type, struct dwarf2_cu *cu,
{
sym->hash_next = objfile->template_symbols;
objfile->template_symbols = sym;
- list_to_add = NULL;
}
if (list_to_add != NULL)