This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 2/2] Use custom hash function with bcache [Re: [RFC] Use custom hash function with bcache]

>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> Revised patch attached.
Sami> Create and use a specialized bcache type for psymbols

Thanks for doing this.  A couple nits, nothing major.

Sami> +/* A bcache for partial symbols.  */
Sami> +
Sami> +struct psymbol_bcache
Sami> +{
Sami> +    struct bcache *bcache;

Too much indentation here.

Since psymbol_bcache is only used in psymtab.c, the definition should be
moved there, leaving just a forward declaration of the tag in psymtab.h.
This makes the type opaque, which is generally better.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]