This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete]


On 08/20/2010 05:54 PM, Tom Tromey wrote:
"Sami" == sami wagiaalla<swagiaal@redhat.com> writes:

Sami> suppressed one too many regressions. Specifically (if you look at Sami> 3b26cb4b133^) the regression on line 10185 when the tag is Sami> DW_TAG_template_value_param and DW_AT_location != NULL.

I don't think this patch is correct.
IIUC it will go ahead and add the template parameters to whatever scope
is being read.  That isn't right, and in fact that is what suppress_add
was intended to prevent.

I looked into this some more. Here is the problem IIUC:


The template parameter P in this case is a member of the structure not the function, but, from what I can tell, the template param patch (240d54e9) supports storing and searching of template parameters only if they are members of a function. If that is correct then this patch just exposed that problem as opposed to case the regression.

Sami


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]