This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Code cleanup: Make function typedef for find memory region


> gdb/
> 2010-08-30  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Code cleanup.
> 	* defs.h (find_memory_region_t): New typedef.
> 	(exec_set_find_memory_regions): Use it.
> 	* exec.c (exec_set_find_memory_regions): Use find_memory_region_t.
> 	* fbsd-nat.c (fbsd_find_memory_regions): Likewise.
> 	* gcore.c (objfile_find_memory_regions): Likewise.
> 	* gnu-nat.c (gnu_find_memory_regions): Likewise.
> 	* linux-nat.c (linux_nat_find_memory_regions): Likewise.
> 	* procfs.c (iterate_over_mappings_cb_ftype): Remove.
> 	(iterate_over_mappings): Rename iterate_over_mappings_cb_ftype to
> 	find_memory_region_t.
> 	(insert_dbx_link_bpt_in_region): Likewise.
> 	(iterate_over_mappings): Likewise.  Drop the comment part about the
> 	function prototype.
> 	(find_memory_regions_callback): Use find_memory_region_t.
> 	(proc_find_memory_regions): Likewise.
> 	(info_mappings_callback): Rename iterate_over_mappings_cb_ftype to
> 	find_memory_region_t.
> 	* target.c (dummy_find_memory_regions): Use find_memory_region_t.
> 	* target.h (struct target_ops) <to_find_memory_regions>: Likewise.

Given the various comments so far, this patch is OK with the type
renamed to find_memory_region_ftype.


-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]