This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix uiout for execute_command_to_string


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> Updated the patch with this part.  Paul Bolle said he does not have
Jan> a signed FSF copyright assignment; if it matters in this case.

It doesn't, that patch is short enough.

Jan> 2010-09-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	    Paul Bolle  <pebolle@tiscali.nl>

One nit.

Jan> +struct cleanup *
Jan> +make_cleanup_ui_out_redirect_pop (struct ui_out *uiout)
Jan> +{
Jan> +  return make_my_cleanup (&cleanup_chain, do_ui_out_redirect_pop, uiout);
Jan> +}

The two new functions need header comments.
Ok with that change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]