This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][patch] Tweak output of -var-info-path-expression


>>>>> "Marc" == Marc Khouzam <marc.khouzam@ericsson.com> writes:

Marc> Bug 11912 (http://sourceware.org/bugzilla/show_bug.cgi?id=11912)
Marc> is causing a syntax error when casting to a class in
Marc> certain cases. (see small session below for example)  

Marc> I'm suggesting to add the workaround to the output of 
Marc> -var-info-path-expression when it casts.

Marc> It would be nicer to fix the parser problem but that
Marc> seems much more complicated (at least for me).

I hate to work around other bugs, but in this case it seems practical.

Marc> I've attached a patch in hopes of comments but I have to 
Marc> admit that the implications of this change are not clear to me.

Marc> Thanks for any feedback

I think a regression test in the test suite would be valuable.

Marc> 2010-09-08  Marc Khouzam  <marc.khouzam@ericsson.com>
Marc> 	* varobj.c (cplus_describe_child): Add `class'
Marc> 	keyword to avoid confusion with constructor name.

I think the patch itself is ok, but I would like to wait a little while
to see if other maintainers, particularly Volodya, have any objections.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]