This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [RFC] python: gdb.Type: strip typedefs past pointers too


On Sat, 2010-09-18 at 10:12 -0400, Joel Brobecker wrote:
> Personally, I think that the current behavior is correct.  But I did
> not participate in the design of the API, so others will probably
> have a more informed opinion.
> 
> If we want to support the behavior you are looking for, I think it
> should be done either through the control of a parameter (defaulted
> to current behavior), or another method (recursive_strip_typedef).

The documentation reads:
>   -- Method on Type: strip_typedefs
>       Return a new `gdb.Type' that represents the real type, after
>       removing all layers of typedefs.

I feel that both the name of this function (which uses typedefs in
plural) and the documentation imply the behavior my patch tries to
achieve.

> Small nit on the coding style: the `||' should be at the beginning
> of the next line:

This nit (and the later one) I'll try to remember.

> (how about references?)

I have no idea. References are C++ things, aren't they?


Paul Bolle


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]