This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

FYI: minor fix to value_entirely_optimized_out


I am checking this in.

While reading code I noticed that value_entirely_optimized_out is
checking the wrong field in the computed functions structure.

This can't currently cause any problem, because the only instance of
this structure that defines check_any_valid also defines check_validity.

Tom

2010-11-17  Tom Tromey  <tromey@redhat.com>

	* value.c (value_entirely_optimized_out): Check the
	'check_any_valid' field.

Index: value.c
===================================================================
RCS file: /cvs/src/src/gdb/value.c,v
retrieving revision 1.116
diff -u -r1.116 value.c
--- value.c	16 Nov 2010 22:13:02 -0000	1.116
+++ value.c	17 Nov 2010 19:47:38 -0000
@@ -519,7 +519,7 @@
   if (!value->optimized_out)
     return 0;
   if (value->lval != lval_computed
-      || !value->location.computed.funcs->check_validity)
+      || !value->location.computed.funcs->check_any_valid)
     return 1;
   return !value->location.computed.funcs->check_any_valid (value);
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]