This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Renaming: {insert,remove} += _location [Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops]

From: Joel Brobecker <brobecker at adacore dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Thiago Jung Bauermann <bauerman at br dot ibm dot com>, Pedro Alves <pedro at codesourcery dot com>, gdb-patches at sourceware dot org
Date: Thu, 18 Nov 2010 09:13:07 -0800
Subject: Re: [patch] Renaming: {insert,remove} += _location [Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops]
References: <1282074071.2606.702.camel@hactar> <201010161843.43062.pedro@codesourcery.com> <1287534691.2686.17.camel@hactar> <20101116040625.GB19243@host0.dyn.jankratochvil.net> <20101116080721.GC4434@adacore.com> <20101116185101.GA32061@host0.dyn.jankratochvil.net> <20101117034707.GB12159@host0.dyn.jankratochvil.net>

> gdb/
> 2010-11-17  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Code cleanup - renaming.
> 	* breakpoint.c (insert_bp_location): Use the new name
> 	breakpoint_ops->insert_location.
> 	(remove_breakpoint_1): Use the new name
> 	breakpoint_ops->remove_location.
> 	* breakpoint.h (struct breakpoint_ops): Rename insert to
> 	insert_location and remove to remove_location.

I didn't think it would change much, but I changed my mind - I like
this change! Thanks for pursuing this.

-- 
Joel

References:
- Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops
  - From: Jan Kratochvil
- Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops
  - From: Joel Brobecker
- Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops
  - From: Jan Kratochvil
- [patch] Renaming: {insert,remove} += _location [Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops]
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]