This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: cast away hw/device differences


On Monday, November 15, 2010 21:57:22 Mike Frysinger wrote:
> When building with device and hw support, the sim-core code generates a
> lot of build time warnings such as:
> 
> ./../common/sim-core.c: In function 'sim_core_map_attach':
> ./../common/sim-core.c:198:7: warning: passing argument 1 of 'device_error'
> from incompatible pointer type ../common/sim-core.h:347:6: note: expected
> 'struct device *' but argument is of type 'struct hw *'
> ./../common/sim-core.c:235:7: warning: passing argument 1 of
> 'device_error' from incompatible pointer type ../common/sim-core.h:347:6:
> note: expected 'struct device *' but argument is of type 'struct hw *'
> 
> In reality, these two structures get cast back and forth in the core
> code already and so are "compatible".  So tweak the three functions
> that generate all of these warnings to include the casts automatically.
> I know this isn't exactly clean, but the current device/hw ifdef
> approach is full of landmines itself and I'm not entirely sure how
> to unscrew it.

ive committed this now
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]