This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfa v2] Detect __aeabi_read_tp even without symbols
- From: Daniel Jacobowitz <dan at codesourcery dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: rearnsha at arm dot com, gdb-patches at sourceware dot org
- Date: Mon, 6 Dec 2010 16:50:38 -0500
- Subject: Re: [rfa v2] Detect __aeabi_read_tp even without symbols
- References: <20101026151740.GA28684@caradoc.them.org> <201012011605.oB1G5Ht5020788@d06av02.portsmouth.uk.ibm.com>
On Wed, Dec 01, 2010 at 05:05:17PM +0100, Ulrich Weigand wrote:
> Dan Jacobowitz wrote:
> > The approach looks good to me. Two comments on the implementation:
> > the explanation is just as valid in the ARM case as the Thumb case,
> > and we should not do this read if we know the name of the target
> > function and it is different from __aeabi_read_tp. Both of these can
> > be accomplished by putting the check in skip_prologue_function
> > instead.
>
> This version implements the suggestion to move the check into
> skip_prologue_function itself (which requires passing some
> additional data into that function).
>
> [ As an aside, the new implementation also avoids the empty-
> statement construct that Mark disliked ... ]
>
> Re-tested with same results on armv7l-linux-gnueabi.
>
> OK for mainline?
Looks good to me.
--
Daniel Jacobowitz
CodeSourcery