This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH, V850] Add support for V850E2 and V850E2V3


Hi,

Thank you for the review comments.

I have updated the patch based on the review comments from Kevin Buettner.
Please find the updated patch "v850-gdb-v850e2-v850e2v3-support.patch".

>
> Why are you changing the register number for E_PC_REGNUM?   I
> assume you've already changed gcc so that the dwarf2 return address
> column ends up being this new number.  Won't this make it impossible
> to use an old compiler with a new debugger and vice versa?
>

I have updated the patch to have the same value for the E_PC_REGNUM. 
The enum members for the new registers for E2V3 are added at the end 
of the enum.


>
> Does the original v850 really have all of these new registers?  (The
> v850 manual that I looked at does not show them...)
>

No, the registers are not available for v850 target. It is only 
available in E2 targets. The patch has been modified accordingly.



The patch adds support for new target variants of V850 i.e. V850E2 and V850E2V3. These processors are upwardly compatible with earlier V850 targets already supported in the current binutils port. V850E2V3 target supports floating point operations. Hence, those instructions along with registers supported by V850E2V3 are defined in the current patch.

The GCC, Binutils and Newlib part of the support have been posted and accepted.

Please review the patch and let me know if there should be any modifications in it. 

2010-12-10  Rathish.C  <rathish.c@kpitcummins.com>
	
	* gdb/v850-tdep.c: Add the enum values for mpu and fpu registers
	(v850_register_name): Add the mpu and fpu register names.
	(v850e_register_name): Add the mpu and fpu register names.
	(v850e2_register_name): New function.
	(v850_gdbarch_init): Add case for bfd_mach_v850e2 and 
	bfd_mach_v850e2v3.
	* sim/common/sim-trace.c: Update the function prototype of 
	save_data_size.
	Move the enum data_fmt from here
	* sim/common/sim-trace.h: to here.
	Add function prototype of save_data
	* sim/v850/sim-main.h: Update the struct _v850_regs to include
	mpu and fpu system registers.
	Define the macros to access the mpu and fpu system registers.
	(SEXT3): Define.
	(TRACE_FP_INPUT_FPU1, TRACE_FP_INPUT_FPU2,
	TRACE_FP_INPUT_FPU3): Define.
	(TRACE_FP_INPUT_BOOL1_FPU2): Define.
	(TRACE_FP_INPUT_WORD2): Define.
	(TRACE_FP_RESULT_WORD1, TRACE_FP_RESULT_WORD2): Define.
	* sim/v850/simops.c: Update the function prototype of Add32
	(update_fpsr): New function.
	(SignalException): New function.
	(SignalExceptionFPE): New function.
	(check_invalid_snan): New function.
	(v850_float_compare): New function.
	(v850_div): New function.
	(v850_divu): New function.
	(v850_sar): New function.
	(v850_shl): New function.
	(v850_shr): New function.
	(v850_satadd): New function.
	(v850_satsub): New function.
	(load_data_mem): New function.
	(store_data_mem): New function.
	(mpu_load_mem_test): New function.
	(mpu_store_mem_test): New function.
	* sim/v850/simops.h: Add function prototype for above
	mentioned functions.
	(check_cvt_fi, check_cvt_if, check_cvt_ff): Define.
	* sim/v850/v850-dc: Add entry for v850e2 and v850e2v3.
	* sim/v850/v850.igen: Add support for v850e2 and v850e2v3

Thanks & Regards,
Rathish.C

Attachment: v850-gdb-v850e2-v850e2v3-support.patch
Description: v850-gdb-v850e2-v850e2v3-support.patch


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]