Re: [PATCH] MI disassemble opcode support

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Wed, 15 Dec 2010 13:32:05 +0000
> From: "Andrew Burgess" <aburgess@broadcom.com>
> 
> Provide an equivalent to "disassemble /r" for the MI interface. The mode parameter to -data-disassemble is extended to control opcode dumping.

Thanks.

> I've updated the docs in gdb/doc/gdb.texinfo but I didn't know what I was supposed to do to update the gdb/doc/gdb.info-4 file

Nothing.  gdb.info-* files are produced from gdb.texinfo when GDB is
built.

> 2010-12-10  Andrew Burgess  <aburgess@broadcom.com>
> 
>           * gdb.texinfo: Update to reflect changes in mi/mi-cmd-disas.c

The ChangeLog entry should show the name of the node where this change
was made (as if the node were a function).

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -27567,8 +27567,9 @@ displayed; if @var{lines} is higher than the number of lines between
>  @var{start-addr} and @var{end-addr}, only the lines up to @var{end-addr}
>  are displayed.
>  @item @var{mode}
> -is either 0 (meaning only disassembly) or 1 (meaning mixed source and
> -disassembly).
> +is either 0 (meaning only disassembly), 1 (meaning mixed source and
> +disassembly), 2 (meaning disassembly with raw opcodes), or 3 (meaning
> +mixed source and disassembly with raw opcodes).
>  @end table

This part is okay.

> +   MODE: 0 -- disassembly.
> +         1 -- disassembly and source.
> +         2 -- disassembly            and opcodes.
> +         3 -- disassembly and source and opcodes.

Please edit the last line to be valid English:

          3 -- disassembly, source and opcodes.

The patch for the manual is okay with these changes.