This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, RFC] Changes to sim_store_register API
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 28 Dec 2010 09:53:05 +0400
- Subject: Re: [PATCH, RFC] Changes to sim_store_register API
- References: <89AE14E37D740B4796DC14566DF6325ECB7F5F6770@SJEXCHCCR02.corp.ad.broadcom.com> <89AE14E37D740B4796DC14566DF6325ECB7F8F13FA@SJEXCHCCR02.corp.ad.broadcom.com> <20101214064904.GM2596@adacore.com> <4D07353A.2020404@broadcom.com>
Andrew,
> gdb/ChangeLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * remote-sim.c (gdbsim_store_register): Update API to
> sim_store_register to check more error conditions.
>
> include/gdb/ChangeLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * remote-sim.h (sim_store_register): Update the API
> documentation for this function.
>
> sim/erc32/ChangeLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * interf.c (sim_store_register): Update return value to
> match new API.
>
> sim/h8300/ChangeLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * compile.c (sim_store_register): Update return value to
> match new API.
>
> sim/m32c/ChangesLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * gdb-if.c (sim_store_register): Update return value to
> match new API.
>
> sim/mn10300/ChangeLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * interp.c (sim_store_register): Update return value to
> match new API.
>
> sim/ppc/ChangeLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * gdb-sim.c (sim_store_register): Update return value to
> match new API.
>
> sim/rx/ChangeLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * gdb-if.c (sim_store_register): Update return value to
> match new API.
>
> sim/v850/ChangeLog :
>
> 2010-11-16 Andrew Burgess <aburgess@broadcom.com>
>
> * interp.c (sim_store_register): Update return value to
> match new API.
This looks good to me. Please remember to update the alignement in
your ChangeLog entries before committing (everything should be aligned
on the same column).
--
Joel