Re: [patch] Add tests for JIT debugging interface

[Paul Pluzhnikov <ppluzhnikov at google dot com>]

On Wed, Jan 12, 2011 at 8:57 AM, Yao Qi <yao@codesourcery.com> wrote:

> There are still two failures, which are not about 'set args' in gdbserver.
>
> FAIL: gdb.base/jit.exp: info function jit_function
> FAIL: gdb.base/jit.exp: info function jit_function

Yes, I see that as well.

> info function jit_function^M
> All functions matching regular expression "jit_function":^M
> (gdb) FAIL: gdb.base/jit.exp: info function jit_function
>
> In gdb.log, I find something strange,
>
> (gdb) continue^M
> Continuing.^M
> jit_inferior_init, registering_code = 0^M
> jit_inferior_init, reg_addr = 0x80486c4^M
> jit_inferior_init, jit_descriptor_addr = 0x804a040^M
> Cannot remove breakpoints because program is no longer writable. <-- [1]

And that.

> There is no such error [1] in native gdb test. ?I have no clue on this so
> far.

That's alright -- I was going to fix this area (see "JIT interface slowness"
in gdb@sourceware.org list), and this isn't the only problem -- I also
noticed that we leak several jit_breakpoints on rerun.

> We may re-write jit-main.c a little bit to compute the location of
> jit-solib.so via getcwd() + argv[0], rather than passing arguments of its
> location.

Done slightly differently.

I believe revised patch addresses all comments so far.

Thanks,
-- 
Paul Pluzhnikov


2011-01-12  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* gdb.base/jit.exp: New file.
	* gdb.base/jit-main.c: New file.
	* gdb.base/jit-solib.c: New file.

Attachment: gdb-jit-tests-20110112.txt
Description: Text document