This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit] Fix printing of wide characters (Ada and C)
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 14 Jan 2011 09:52:13 -0700
- Subject: Re: [RFA/commit] Fix printing of wide characters (Ada and C)
- References: <1294960709-13047-1-git-send-email-brobecker@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> (b) The second problem was in c-valprint, where we were down-casting
Joel> the integer value of the character to type `unsigned char',
Joel> causing use to lose all but the lowest byte.
Ouch. I am really surprised we missed this for so long.
Joel> * ada-valprint. (ada_printchar): Use the correct type length
Joel> in call to ada_emit_char.
Joel> * c-valprint.c (c_val_print): Remove cast in call to LA_PRINT_CHAR.
Joel> Tested on x86_64-linux. Ok to commit?
It looks good to me. I think it should go on the 7.2 branch as well.
Tom