This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping: [Patch v2] Add mips*-linux* catch syscall support.

On 01/31/2011 11:45 AM, Michael Snyder wrote:
David Daney wrote:
If it is not too much trouble, could a Maintainer review this patch?

Thanks in advance,
David Daney

There's an off-by-one indentation here:


+static LONGEST
+mips_linux_get_syscall_number (struct gdbarch *gdbarch,
+ ptid_t ptid)


Good catch. If approved, I would commit the corrected version.


Other than that, the part in mips-linux-tdep.c looks reasonable.
I don't understand the xml parts well enough to comment.


Thanks for looking at it, now to get someone to give the official 'OK'

David Daney


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]