This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Implement support for PowerPC BookE ranged breakpoints


> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 31 Jan 2011 16:59:04 -0200
> 
> > > +  a Linux kernel version 2.6.34 or later, GDB supports ranged breakpoints,
> > > +  which stop execution of the inferior whenever it executes any address
> > > +  within the specified range.  See the "PowerPC Embedded" section in the
> > 
> > "whenever it executes an instruction at any address within the
> > specified range".  (You cannot "execute" an address.)
> 
> It was an analogy with "read an address" and "write an address", but I
> guess even those expressions are not that good. :-) Fixed.

"Read from an address" and "write to an address" would be better, yes.

> > > +      sals_start.sals = (struct symtab_and_line *)
> > > +	xmalloc (sizeof (struct symtab_and_line));
> > > +      sals_start.nelts = 1;
> > 
> > Spaces and TABs mixup alert!
> 
> Hum, I couldn't find the mixup. the lines above and below xmalloc need
> to use spaces because they start at column 7. The xmalloc line uses TAB
> since it starts at column 9 (and it doesn't have any spaces only one
> TAB).

Then it's my mixup, sorry.  Disregard that comment.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]