This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: add user_breakpoint_p


On Tuesday 01 February 2011 03:05:44, Joel Brobecker wrote:
> > >> -    if (!user_settable_breakpoint (tp) || tp->number < 0)
> > >> +    if (! user_breakpoint_p (tp))
> > 
> > Joel> Do we agree on whether to write this as the above, or whether we should
> > Joel> not have a space between the '!' and the expression being negated:
> > 
> > I have trouble remembering whether we have a rule here.
> > I will remove the space.  It doesn't matter to me either way if we have
> > it or not.
> 
> It doesn't matter to me either way, althought I have a slight preference
> for no space.  I'd like us to agree and make a "soft" recommendation on
> my wiki page about the GDB Coding Style.

I still have in my queue to post a patch per:

 <http://sourceware.org/ml/gdb-patches/2010-11/msg00121.html>

If you guys are still okay with it, I'll bump it close to the
the top of my today's TODO.  (I'm okay with having this in
the wiki as well).

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]