This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Implement support for IBM XL C for OpenCL vector ABI


>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:

Ulrich> This extra flag is defined by GDB itself, and has a value outside
Ulrich> the defined range of DW_AT_calling_convention attribute values,
Ulrich> so there should be no potential conflict.

Ulrich> Does this look reasonable?  If anyone sees a better way to implement
Ulrich> this, I'd appreciate any suggestions ...

I think it would be slightly more future-proof to choose a value in the
lo_user-hi_user range and put the new name, along with a detailed
comment, into include/dwarf2.h.

That way, if somebody finds a conflicting use, presumably they will be
editing the same place, see the comment, and change the value to
something that does not conflict.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]