This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC] Update description of parse_breakpoint_sals
- From: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- To: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Fri, 04 Feb 2011 15:32:40 -0200
- Subject: [RFC] Update description of parse_breakpoint_sals
Hi,
The comment describing parse_breakpoint_sals is outdated. This patch
updates it and expands it a bit. I was tempted to just commit it as
obvious, but people more familiar with the function may have something
to add or comment to my new description...
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
2011-02-04 Thiago Jung Bauermann <bauerman@br.ibm.com>
* breakpoint.c (parse_breakpoint_sals): Fix description.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 656dedd..39d9b02 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -7485,10 +7485,13 @@ create_breakpoints_sal (struct gdbarch *gdbarch,
}
}
-/* Parse ARG which is assumed to be a SAL specification possibly
+/* Parse ADDRESS which is assumed to be a SAL specification possibly
followed by conditionals. On return, SALS contains an array of SAL
addresses found. ADDR_STRING contains a vector of (canonical)
- address strings. ARG points to the end of the SAL. */
+ address strings. ADDRESS points to the end of the SAL.
+
+ The array and the line spec strings are allocated on the heap, it is
+ the caller's responsibility to free them. */
static void
parse_breakpoint_sals (char **address,