This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Support inferior events in python


>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> Did you mean "or, get_event_thread" here ? I assumed so because
Sami> get_event_thread can indeed return NULL without setting an error. I
Sami> have fixed that be adding a call to PyErr_SetString.
Sami> create_event_object on the other hand fails only due to failures in
Sami> calls into the Python api. Which, presumably, do set errors.

I don't remember :)
But, I read this iteration of the patch and what you did is fine.

Sami> +2011-01-21  Sami Wagiaalla  <swagiaal@redhat.com>
Sami> +                Oguz Kayral <oguzkayral@gmail.com>

This is ok.  Thanks for persevering, and congratulations.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]