This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gdb: Incorrect stack unwinding if compressed debug info is used


On 02/04/2011 11:31 PM, Tom Tromey wrote:
Vladimir>  May be just change dwarf2_read_section to return
Vladimir>  size?

I think the name is ok, but I extended the comment to try to clear up
the semantics.

I am going to check in the appended patch.  If you still think the name
is not good, pick a better one and I will rename it.

Please see attached patch. Hope it explains what I meant under "change dwarf2_read_section". If such changes are not acceptable by some reason(performance?, readability?, something else) then I'm OK with current naming.

I definitely don't insist on such changes, I just interested
in understanding gdb "coding policy". If it is difficult
to explain please ignore this mail.

Best regards
Vladimir Simonov

Attachment: gdb-7.2-compressed-section-cleanup.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]