This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
I do not fully understand the reasons for part (b). The old code is not nice but IMO neither is the new code (already checked in by the physname patch) due to the linespec.c caller.
Moreover the new code has shown its regressions.
If the code should be nice I tried archer-jankratochvil-linespec where linespec is based on the expressions. Noted by Daniel Jacobowitz before: http://sourceware.org/ml/gdb-patches/2009-11/msg00266.html
That is in general I would be either for futher not-nice fixing up the pre-physname code or for the expression way like archer-jankratochvil-linespec does. Still at the moment your patchset gives the best user experience, just it is a new untested code which does not make it nice anyway.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |