This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] tracepoint: add new trace command "printf"[0] gdb
- From: Hui Zhu <teawater at gmail dot com>
- To: Doug Evans <dje at google dot com>, Stan Shebs <stan at codesourcery dot com>, Michael Snyder <msnyder at vmware dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Fri, 11 Feb 2011 11:49:15 +0800
- Subject: Re: [PATCH] tracepoint: add new trace command "printf"[0] gdb
- References: <AANLkTimhMH+qUE1NmQ+f6+L8BcEU+k07eU+M9B-gLsrk@mail.gmail.com> <AANLkTik=K4Dk-Mkc5P7DDofzqwThhE6LvCM4rT-U_LNt@mail.gmail.com> <AANLkTiktJB=V0KS0u31rWMA6CyoV6J3+9Yufcgr=efr-@mail.gmail.com> <AANLkTinOj2JE8U=cu1ntVfh7nmTwnKDTox22da09vfyF@mail.gmail.com> <4D24D9DD.8090104@codesourcery.com> <AANLkTi=K3tw6_-uYDL8W4mSaL6nFPx-N541ALMC9-JZX@mail.gmail.com> <AANLkTik3mLyEUb4wRCbuG4X10=+Dp0_myYSC+kSjkzbL@mail.gmail.com> <AANLkTinOejC4S1cwA_uxdjWbpveLvR7C==mJMSSrw-aH@mail.gmail.com>
Hi all,
I sent the first version patch has been more than a month. And I have
done with the support in the KGTP for the support.
But I am still not get a code review or something. Are you reviewing
or have plan to review this patch?
Thanks,
Hui
On Fri, Feb 4, 2011 at 23:59, Hui Zhu <teawater@gmail.com> wrote:
> The prev version cannot support %s. ?So make a new version to support it.
>
> And I think current way to handle printf is too much hack way. ?Maybe
> I need find out a more better way to handle the printf.
>
> Thanks,
> Hui
>
> 2011-02-04 ?Hui Zhu ?<teawater@gmail.com>
>
> ? ? ? ?* ax-gdb.c (gen_printf_expr_callback): New function.
> ? ? ? ?* ax-general.c (ax_memcpy): New function.
> ? ? ? ?(aop_map): Add new entry for "printf".
> ? ? ? ?(ax_print): Handle "printf".
> ? ? ? ?(ax_reqs): Ditto.
> ? ? ? ?* ax.h (agent_op): Add aop_printf.
> ? ? ? ?(ax_memcpy): Forward declare.
> ? ? ? ?* printcmd.c (printf_callback): New typedef.
> ? ? ? ?(string_printf): New function from ui_printf.
> ? ? ? ?(ui_printf): Call string_printf.
> ? ? ? ?(printf_command): Remove static.
> ? ? ? ?* tracepoint.c (printf_command, gen_printf_expr_callback,
> ? ? ? ?printf_callback, string_printf): Forward declares.
> ? ? ? ?(validate_actionline, encode_actions_1): handle printf_command.
>