This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [unavailable values part 1, 05/17] move traceframe memory reading fallback to read-only sections to GDB side
Continuing addressing your review piecemeal...
On Tuesday 15 February 2011 12:00:08, Jan Kratochvil wrote:
> On Mon, 07 Feb 2011 15:30:29 +0100, Pedro Alves wrote:
> > +/* Using the set of read-only target sections of OPS, read live
> > + read-only memory. Note that the actual reads start from the
> > + top-most target again. */
>
> /* The return is the same as that of target_read. */
>
> > +
> > +static LONGEST
> > +memory_xfer_live_readonly_partial (struct target_ops *ops,
Thanks. I've applied the below, memory_xfer_partial already
uses the same style.
Pedro Alves
2011-02-15 Pedro Alves <pedro@codesourcery.com>
Jan Kratochvil <jan.kratochvil@redhat.com>
gdb/
* target.c (memory_xfer_live_readonly_partial): Document where to
look for interface description.
---
gdb/target.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: src/gdb/target.c
===================================================================
--- src.orig/gdb/target.c 2011-02-14 11:21:27.000000000 +0000
+++ src/gdb/target.c 2011-02-15 16:16:38.418123003 +0000
@@ -1297,7 +1297,10 @@ target_read_live_memory (enum target_obj
/* Using the set of read-only target sections of OPS, read live
read-only memory. Note that the actual reads start from the
- top-most target again. */
+ top-most target again.
+
+ For interface/parameters/return description see target.h,
+ to_xfer_partial. */
static LONGEST
memory_xfer_live_readonly_partial (struct target_ops *ops,