This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [unavailable values part 1, 06/17] array element repeats, <unavailable> confused with 0.


On Tue, 15 Feb 2011 19:28:35 +0100, Pedro Alves wrote:
> Indeed.  Could you double-check the patch below?

It seems correct to me now.


> -      if (memcmp (val1->contents + org_offset1 + prev_avail,
> -		  val2->contents + org_offset2 + prev_avail,
> -		  l2 - prev_avail) != 0)
> +      if (memcmp (val1->contents + offset1, val2->contents + offset2, l1) != 0)

[nitpick] GNU Coding standards says 78 columns (this is 79), OTOH Joel said he
already uses 80.  http://sourceware.org/ml/gdb-patches/2011-01/msg00255.html


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]