This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] testsuite: dw2-ranges: declare function descriptors for ppc64 compatibility


> 2011-02-16  Edjunior Machado  <emachado@br.ibm.com>
> 
> gdb/
> 	* gdb.dwarf2/dw2-ranges.S: Add .opd section with function
> 	descriptors for ppc64 compatibility.
> 	* gdb.dwarf2/dw2-ranges2.S: Likewise.
> 	* gdb.dwarf2/dw2-ranges3.S: Likewise.

No objection from my end, but just some thoughts on this testcase,
aimed mostly at Jan:

  - Do we really need to start the testcase at all.  The comment
    explains why we do this, but does this testcase in particular
    bring something extra?

  - Can we maybe tweak the testcase so that the main function is
    written in C, rather than ASM.  Then have the C function call
    the old main, and the testcase run until the beginning on main.
    Would things work with powerpc64 as well, if we did that?

I'm just a little concerned about polutting the essence of the
assembly file with target-specific stuff, so if we can avoid it...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]