This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] testsuite: dw2-ranges: declare function descriptors for ppc64 compatibility
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 17 Feb 2011 09:45:45 +0400
- Subject: Re: [PATCH] testsuite: dw2-ranges: declare function descriptors for ppc64 compatibility
- References: <1297882017-19802-1-git-send-email-emachado@linux.vnet.ibm.com>
> 2011-02-16 Edjunior Machado <emachado@br.ibm.com>
>
> gdb/
> * gdb.dwarf2/dw2-ranges.S: Add .opd section with function
> descriptors for ppc64 compatibility.
> * gdb.dwarf2/dw2-ranges2.S: Likewise.
> * gdb.dwarf2/dw2-ranges3.S: Likewise.
No objection from my end, but just some thoughts on this testcase,
aimed mostly at Jan:
- Do we really need to start the testcase at all. The comment
explains why we do this, but does this testcase in particular
bring something extra?
- Can we maybe tweak the testcase so that the main function is
written in C, rather than ASM. Then have the C function call
the old main, and the testcase run until the beginning on main.
Would things work with powerpc64 as well, if we did that?
I'm just a little concerned about polutting the essence of the
assembly file with target-specific stuff, so if we can avoid it...
--
Joel