This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc, testsuite] Standardize tests for HW watchpoint capabilities
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 17 Feb 2011 14:18:34 +0400
- Subject: Re: [rfc, testsuite] Standardize tests for HW watchpoint capabilities
- References: <201102170953.p1H9rxCI010550@d06av02.portsmouth.uk.ibm.com>
> To fix these problems, I've added a couple of new skip_..._tests
> procedures to lib/gdb.exp, and have updated all related test cases
> to make use of those procedures instead of open-coding checks.
Generally speaking, I think this is the way to go (that's what we do
in AdaCore's testsuite infrastructure [which does not use dejagnu]).
> The new procedures allow checking for:
>
> - skip_hw_breakpoint_tests: Guards tests of hardware breakpoints
> - skip_hw_watchpoint_tests: Guards tests of hardware watchpoints
> - skip_hw_watchpoint_multi_tests: Guards tests that require more
> than one hardware watchpoint to be active at the same time
> - skip_hw_watchpoint_access_tests: Guards tests that require
> read or access type hardware watchpoints
[...]
> Any comments? I'm planning to commit this in a couple of days ...
I only skimmed the actual changes, and while spending a little more
time checking the implementation of the routines above. It looks
fine to me. Nice improvement, IMO - thanks!
--
Joel