This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] C++ operators do not resolve through typedefs
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 18 Feb 2011 16:57:51 +0100
- Subject: [patch] C++ operators do not resolve through typedefs
Hi,
https://bugzilla.redhat.com/show_bug.cgi?id=678454
operators do not get resolved through a typedef.
The other unrelated part is that GDB crashes when trying to resolve operator
without running inferior. I did not split it to a separate mail as I find it
separated here well enough.
No regressions on {x86_64,x86_64-m32,i686}-fedora15-linux-gnu.
I find it safe enough so I will check it in in some time.
Thanks,
Jan
gdb/
2011-02-18 Jan Kratochvil <jan.kratochvil@redhat.com>
* cp-support.c (make_symbol_overload_list_namespace) Do not call
make_symbol_overload_list_block with NULL BLOCK.
* valarith.c (unop_user_defined_p): Resolve also TYPE_CODE_TYPEDEF.
gdb/testsuite/
2011-02-18 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.cp/typedef-operator.exp: New file.
* gdb.cp/typedef-operator.cc: New file.
--- a/gdb/cp-support.c
+++ b/gdb/cp-support.c
@@ -778,11 +778,13 @@ make_symbol_overload_list_namespace (const char *func_name,
/* Look in the static block. */
block = block_static_block (get_selected_block (0));
- make_symbol_overload_list_block (name, block);
+ if (block)
+ make_symbol_overload_list_block (name, block);
/* Look in the global block. */
block = block_global_block (block);
- make_symbol_overload_list_block (name, block);
+ if (block)
+ make_symbol_overload_list_block (name, block);
}
--- a/gdb/valarith.c
+++ b/gdb/valarith.c
@@ -315,15 +315,26 @@ unop_user_defined_p (enum exp_opcode op, struct value *arg1)
if (op == UNOP_ADDR)
return 0;
type1 = check_typedef (value_type (arg1));
- for (;;)
+ while (type1)
{
if (TYPE_CODE (type1) == TYPE_CODE_STRUCT)
return 1;
else if (TYPE_CODE (type1) == TYPE_CODE_REF)
type1 = TYPE_TARGET_TYPE (type1);
+ else if (TYPE_CODE (type1) == TYPE_CODE_TYPEDEF)
+ {
+ struct type *type2 = check_typedef (type1);
+
+ /* Abort if this TYPE_CODE_TYPEDEF cannot be resolved. */
+ if (type2 == type1)
+ break;
+
+ type1 = type2;
+ }
else
- return 0;
+ break;
}
+ return 0;
}
/* Try to find an operator named OPERATOR which takes NARGS arguments
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/typedef-operator.cc
@@ -0,0 +1,29 @@
+/* This test case is part of GDB, the GNU debugger.
+
+ Copyright 2011 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+class C
+{
+public:
+ int operator* () { return 42; }
+};
+typedef C D;
+D u;
+D &v = u;
+int main ()
+{
+ return *v;
+}
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/typedef-operator.exp
@@ -0,0 +1,33 @@
+# Copyright 2011 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# This file is part of the gdb testsuite.
+
+if {[skip_cplus_tests]} { continue }
+
+set testfile "typedef-operator"
+if [prepare_for_testing $testfile $testfile $testfile.cc {c++ debug}] {
+ return -1
+}
+
+gdb_test_no_output "set language c++"
+
+gdb_test "p *u" {You can't do that without a process to debug.} "test crash"
+
+if ![runto_main] {
+ return -1
+}
+
+gdb_test "p *v" " = 42" "test typedef"