This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] mingw port: Allow use of cvs GDB on Windows 95


> +  /* Stop any pending selects. On Windows 95 OS, CancelIo function does not
> +     exist. In that case, it can be replaced by a call to CloseHandle, but
> +     this is not necessary here as we do close the Windows handle by
> calling
> +     close (scb->fd) below.  */

Thanks for adding the comment.  You forgot to add a second space after
the period on the second line... And while I'm nitpicking (I really
apologize), we had a discussion about line length and sort of agreed
on a "soft" limit of 70 characters, and a hard limit of 79, or 80.
Can you try a little shorter lines? (ironic, I know). I promise,
I wouldn't be nitpicking if you weren't going to touch it :).

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]