This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] mingw port: Allow use of cvs GDB on Windows 95
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 21 Feb 2011 15:58:05 +0400
- Subject: Re: [RFA] mingw port: Allow use of cvs GDB on Windows 95
- References: <001201cbc46c$5b95b100$12c11300$@muller@ics-cnrs.unistra.fr> <000001cbc473$6ef9d120$4ced7360$@muller@ics-cnrs.unistra.fr> <002401cbc574$a8d990e0$fa8cb2a0$@muller@ics-cnrs.unistra.fr> <20110221102151.GG2600@adacore.com> <009301cbd1bd$88ed0550$9ac70ff0$@muller@ics-cnrs.unistra.fr>
> + /* Stop any pending selects. On Windows 95 OS, CancelIo function does not
> + exist. In that case, it can be replaced by a call to CloseHandle, but
> + this is not necessary here as we do close the Windows handle by
> calling
> + close (scb->fd) below. */
Thanks for adding the comment. You forgot to add a second space after
the period on the second line... And while I'm nitpicking (I really
apologize), we had a discussion about line length and sort of agreed
on a "soft" limit of 70 characters, and a hard limit of 79, or 80.
Can you try a little shorter lines? (ironic, I know). I promise,
I wouldn't be nitpicking if you weren't going to touch it :).
--
Joel