This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] mingw port: Allow use of cvs GDB on Windows 95
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Joel Brobecker'" <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 21 Feb 2011 13:51:33 +0100
- Subject: RE: [RFA] mingw port: Allow use of cvs GDB on Windows 95
- References: <001201cbc46c$5b95b100$12c11300$@muller@ics-cnrs.unistra.fr> <000001cbc473$6ef9d120$4ced7360$@muller@ics-cnrs.unistra.fr> <002401cbc574$a8d990e0$fa8cb2a0$@muller@ics-cnrs.unistra.fr> <20110221102151.GG2600@adacore.com> <009301cbd1bd$88ed0550$9ac70ff0$@muller@ics-cnrs.unistra.fr> <20110221115805.GK2600@adacore.com>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé?: lundi 21 février 2011 12:58
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA] mingw port: Allow use of cvs GDB on Windows 95
>
> > + /* Stop any pending selects. On Windows 95 OS, CancelIo function
> does not
> > + exist. In that case, it can be replaced by a call to
> CloseHandle, but
> > + this is not necessary here as we do close the Windows handle by
> > calling
> > + close (scb->fd) below. */
>
> Thanks for adding the comment. You forgot to add a second space after
> the period on the second line...
And on the first line too...
> And while I'm nitpicking (I really
> apologize), we had a discussion about line length and sort of agreed
> on a "soft" limit of 70 characters, and a hard limit of 79, or 80.
> Can you try a little shorter lines? (ironic, I know). I promise,
> I wouldn't be nitpicking if you weren't going to touch it :).
I can at least try...
see below, but if I remove "CloseHandle," from the second line,
it gets a line length of 62, which is too short, so that I presumed
that as long as the line length with it is less than 80, it is still OK?
Just tell me if this is correct.
Pierre
PS: I just saw that I also have an unwanted "src/gdb/" in my
ChangeLog entry that I will fix at the same time...
ChangeLog entry:
2011-02-21 Pierre Muller <muller@ics.u-strasbg.fr>
* ser-mingw.c (ser_windows_close): Reformat comment to better
conform
to GNU coding standards.
Index: ser-mingw.c
===================================================================
RCS file: /cvs/src/src/gdb/ser-mingw.c,v
retrieving revision 1.27
diff -u -p -r1.27 ser-mingw.c
--- ser-mingw.c 21 Feb 2011 11:47:12 -0000 1.27
+++ ser-mingw.c 21 Feb 2011 12:43:59 -0000
@@ -221,10 +221,10 @@ ser_windows_close (struct serial *scb)
{
struct ser_windows_state *state;
- /* Stop any pending selects. On Windows 95 OS, CancelIo function does not
- exist. In that case, it can be replaced by a call to CloseHandle, but
- this is not necessary here as we do close the Windows handle by
calling
- close (scb->fd) below. */
+ /* Stop any pending selects. On Windows 95 OS, CancelIo function does
+ not exist. In that case, it can be replaced by a call to CloseHandle,
+ but this is not necessary here as we do close the Windows handle
+ by calling close (scb->fd) below. */
if (CancelIo)
CancelIo ((HANDLE) _get_osfhandle (scb->fd));
state = scb->state;