This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Move common macros to i386-common.h


On 02/24/2011 05:17 AM, Mark Kettenis wrote:
> I'm particularly worried about changes I'll make myself.  My primary
> development platform is OpenBSD which isn't supported by gdbserver.
> So I won't be building the gdbserver code, so I won't notice any
> problems my diffs (and other people's diffs) will introduce in
> gdbserver.
> 

Everyone here can only test his/her diff on a limited number of
combination of arch and os.  If diff breaks gdb or gdbserver, it should
be fixed.

> Sharing architecture-specific #define's is probably fine.  Sharing
> some simple basec support functions may also be ok.  But I don't think
> sharing more complicated code (such as the code manipulating the i386
> debug registers) is a good idea.

To my patch, it is like an equivalent transformation.  Code moved in gdb
and gdbserver are exactly 100% same.  AFAICS, i386 debug register
manipulation code is the same on gdb and gdbserver.  Why do you think it
is not a good idea to move them?  Am I missing something?

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]