This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 16/18] Add tdep files for x86 and powerpc.
> The i386 bits have my blessing. The powerpc bits look a bit weird though:
Thanks for the review :).
> This bit of code looks like it is trying to support both stacks
> growing up and stack growing down. Does that really happen on
> VxWorks? Your code doesn't call set_gdbarch_inner_than(), so at least
> one of these branches must be dead code.
You are right to be puzzled by this code.
This code is actually a copy of a function that, as luck has it,
you removed a while ago because it was no longer used. It was
called something like generic_push_dummy_code. At the time,
I just copied the old function over.
In any case, I don't believe that I can have both direction on
powerpc-vxworks either, so I will clean it up.
--
Joel