This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] reattach_breakpoints: avoid resource leak.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 26 Feb 2011 17:55:53 -0800
- Subject: [commit] reattach_breakpoints: avoid resource leak.
Found by coverity.
2011-02-26 Michael Snyder <msnyder@vmware.com>
* breakpoint.c (reattach_breakpoints): Avoid resource leak (ui_file).
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.541
diff -u -p -u -p -r1.541 breakpoint.c
--- breakpoint.c 23 Feb 2011 19:20:37 -0000 1.541
+++ breakpoint.c 27 Feb 2011 01:52:59 -0000
@@ -1989,7 +1989,7 @@ reattach_breakpoints (int pid)
struct cleanup *old_chain;
struct bp_location *bl, **blp_tmp;
int val;
- struct ui_file *tmp_error_stream = mem_fileopen ();
+ struct ui_file *tmp_error_stream;
int dummy1 = 0, dummy2 = 0;
struct inferior *inf;
struct thread_info *tp;
@@ -2003,6 +2003,7 @@ reattach_breakpoints (int pid)
inferior_ptid = tp->ptid;
+ tmp_error_stream = mem_fileopen ();
make_cleanup_ui_file_delete (tmp_error_stream);
ALL_BP_LOCATIONS (bl, blp_tmp)