This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] add_symbol_file_command, avoid memory leak.


On Sun, 27 Feb 2011 21:35:46 +0100, Michael Snyder wrote:
> Jan Kratochvil wrote:
> > While a nitpick it is a regression, that dont_repeat should be called even
> > in the case of that error.
> 
> No, it's a fix.  I moved the error before dont_repeat.

Why?  The manual says:
	`add-symbol-file' does not repeat if you press <RET> after using it.
Other part of the manual says:
	and you can repeat certain GDB commands by typing just <RET>.

There is nothing said that whether the command is / is not repated depends on
its entered arguments.

(Not sure if it matters to continue the discussion, I do not mind either way.)


Regards,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]