This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] again, document that case stmt fall through is intentional.
- From: Michael Snyder <msnyder at vmware dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Date: Sun, 27 Feb 2011 13:33:49 -0800
- Subject: Re: [commit] again, document that case stmt fall through is intentional.
- References: <4D697957.5010009@vmware.com> <201102271647.07238.pedro@codesourcery.com>
Pedro Alves wrote:
While this code is duplicated, can you do the
such changes to gdbserver/i386-low.c as well? Thanks.
So committed, as below:
2011-02-27 Michael Snyder <msnyder@vmware.com>
* i386-low.c (i386-length_and_rw_bits): Comment the fact that
a case statement falls through.
Index: i386-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/i386-low.c,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 i386-low.c
--- i386-low.c 1 Jan 2011 15:33:24 -0000 1.5
+++ i386-low.c 27 Feb 2011 21:32:31 -0000
@@ -243,6 +243,7 @@ Invalid hardware breakpoint type %d in i
return (DR_LEN_2 | rw);
case 4:
return (DR_LEN_4 | rw);
+ /* ELSE FALL THROUGH */
case 8:
if (TARGET_HAS_DR_LEN_8)
return (DR_LEN_8 | rw);